Miscellanous diffs#1952
Merged
Merged
Conversation
Contributor
Author
|
Since Chrome doesn't support webRequestBlocking for manifest v3, there's an error that's always present when loading the extension from unpacked source code: As far as I can tell, Chrome can run the extension from unpacked source code and Firefox can't. And there's already custom build logic for separate manifests, so it makes more sense to add the permission there for Firefox than remove it for Chrome. |
gamebeaker
reviewed
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why move FootnoteExtractor to its own file: it makes it easier to work on the util file when the unrelated class isn't at the bottom.
Why move Information page header out of div: Semantically, it makes sense for the h1 to be the top item alone. But also, because I work so heavily with Calibre, this is another thing I end up having to manually edit for every epub. When Calibre generates Table of Contents from files, it uses the first element in the page. If that's a div, it includes everything in the div. So I have to move the h1 above the div or have the table of contents url smooshed in the ToC entry.